Skip to content

feature: [PROD-14860] remove error handling component from SimplePowerBIReportEmbed#437

Merged
edonzeqiri95 merged 1 commit intomainfrom
eze/styled-error-container-component
Nov 10, 2025
Merged

feature: [PROD-14860] remove error handling component from SimplePowerBIReportEmbed#437
edonzeqiri95 merged 1 commit intomainfrom
eze/styled-error-container-component

Conversation

@edonzeqiri95
Copy link
Copy Markdown
Contributor

No description provided.

@edonzeqiri95 edonzeqiri95 force-pushed the eze/styled-error-container-component branch 5 times, most recently from 947c936 to b86b300 Compare November 7, 2025 10:02
@edonzeqiri95 edonzeqiri95 changed the title feature: [PROD-14860] add StyledErrorContainer component feature: [PROD-14860] remove error handling component from SimplePowerBIReportEmbed Nov 7, 2025
Copy link
Copy Markdown
Member

@csm-thu csm-thu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the commit title to match the conventional commits guidelines?
In this case, it is a breaking change, and it's not really a feature nor a bug, so we should probably use something like:

refactor!: [PROD-XXXX] remove error ...

BREAKING CHANGE: the error banner is no longer included in the SimplePowerBIReportEmbed component

…werBIReportEmbed

BREAKING CHANGE: the error banner is no longer included in the SimplePowerBIReportEmbed component
@edonzeqiri95 edonzeqiri95 force-pushed the eze/styled-error-container-component branch from b86b300 to d4b845a Compare November 10, 2025 12:37
@edonzeqiri95 edonzeqiri95 requested a review from csm-thu November 10, 2025 12:41
Copy link
Copy Markdown
Member

@csm-thu csm-thu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@edonzeqiri95 edonzeqiri95 merged commit d21e0b9 into main Nov 10, 2025
2 checks passed
@csm-thu csm-thu deleted the eze/styled-error-container-component branch November 27, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants